Replace Globus with OIDC (Beta, do not merge)#92
Open
juztas wants to merge 3 commits into
Open
Conversation
gabor-lbl
reviewed
May 14, 2026
| "opentelemetry-instrumentation-fastapi>=0.60b1,<0.61b0", | ||
| "opentelemetry-exporter-otlp>=1.39.1,<1.40.0", | ||
| "globus-sdk>=4.3.1", | ||
| "PyJWT>=2.10.1", |
Contributor
There was a problem hiding this comment.
Have you considered a higher level library like authlib? It might take care of some of the validation code in _decode_oidc_jwt. Take a look here: https://docs.authlib.org/en/stable/oauth2/resource-server/flask.html
Contributor
Author
There was a problem hiding this comment.
I have not until now. I think that would be a bigger lift for the codebase. Current IRI needs are basically to validate a signed JWT, check the issuer/aud/exp. I think Authlib provides a full set of server/client tooling. Do we need that?
Contributor
There was a problem hiding this comment.
I think minimizing boilerplate is usually a good idea. Here are two options:
- don't know much about this one: https://fastapi-oidc.readthedocs.io/en/latest/
- the "standard": joserfc with:
- import keyset (jwks): https://jose.authlib.org/en/recipes/cheatsheet/#key-sets-jwks
- decode/validate the jwt: https://jose.authlib.org/en/recipes/cheatsheet/#decode-verify-token (where the 'key' param is the jwks from the prev. step)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.